summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFubo Chen <fubo.chen@gmail.com>2011-03-14 12:06:07 +0100
committerJames Bottomley <James.Bottomley@suse.de>2011-03-23 17:36:45 +0100
commitf45934e08c9640faa5d960633eaf840c29ea33a8 (patch)
tree5b76358913a11b0b8e24da02777feedd7cccef44
parent[SCSI] target: Fix bogus return in transport_add_device_to_core_hba failure path (diff)
downloadlinux-f45934e08c9640faa5d960633eaf840c29ea33a8.tar.xz
linux-f45934e08c9640faa5d960633eaf840c29ea33a8.zip
[SCSI] tcm_mod_builder.py: Fix generated *_drop_nodeacl() handler
This patch adds the missing core_tpg_del_initiator_node_acl() call required by fabric modules for struct se_node_acl->acl_group context shutdown via target_core_fabric_configfs.c:target_fabric_nacl_base_release() -> struct target_core_fabric_ops->fabric_drop_nodeacl() for tcm_mod_builder.py generated $FABRIC_MOD_configfs.c skeleton code. Signed-off-by: Fubo Chen <fubo.chen@gmail.com> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org> Signed-off-by: James Bottomley <James.Bottomley@suse.de>
-rwxr-xr-xDocumentation/target/tcm_mod_builder.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/Documentation/target/tcm_mod_builder.py b/Documentation/target/tcm_mod_builder.py
index 89af6c7a7c8f..7ef9b843d529 100755
--- a/Documentation/target/tcm_mod_builder.py
+++ b/Documentation/target/tcm_mod_builder.py
@@ -289,6 +289,7 @@ def tcm_mod_build_configfs(proto_ident, fabric_mod_dir_var, fabric_mod_name):
buf += "{\n"
buf += " struct " + fabric_mod_name + "_nacl *nacl = container_of(se_acl,\n"
buf += " struct " + fabric_mod_name + "_nacl, se_node_acl);\n"
+ buf += " core_tpg_del_initiator_node_acl(se_acl->se_tpg, se_acl, 1);\n"
buf += " kfree(nacl);\n"
buf += "}\n\n"