diff options
| author | Lee Jones <lee.jones@linaro.org> | 2013-07-19 09:44:50 +0200 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2013-09-02 11:22:42 +0200 |
| commit | f840e23bcf16068eeffe8991ac38b58b82160e43 (patch) | |
| tree | b64992a7d0fe867a6d3482c1d60d4c7056e68fd0 | |
| parent | mfd: timberdale: Use module_pci_driver (diff) | |
| download | linux-f840e23bcf16068eeffe8991ac38b58b82160e43.tar.xz linux-f840e23bcf16068eeffe8991ac38b58b82160e43.zip | |
mfd: ab8500-debugfs: Apply a check for -ENOMEM after allocating memory for sysfs
The AB8500 debugfs driver allocates memory for a new sysfs entry, but
fails to apply the proper post-allocation checks. If the device were to
run out of memory, the allocation would return NULL. Without the correct
checks the driver will continue to populate NULL->[show|store|...],
which would obviously cause a pointer dereference Oops.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
| -rw-r--r-- | drivers/mfd/ab8500-debugfs.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index a0afa64b471b..fe8189c4385a 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -2800,6 +2800,9 @@ static ssize_t ab8500_subscribe_write(struct file *file, */ dev_attr[irq_index] = kmalloc(sizeof(struct device_attribute), GFP_KERNEL); + if (!dev_attr[irq_index]) + return -ENOMEM; + event_name[irq_index] = kmalloc(count, GFP_KERNEL); sprintf(event_name[irq_index], "%lu", user_val); dev_attr[irq_index]->show = show_irq; |