diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-12-10 15:56:01 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2016-12-10 15:56:01 +0100 |
| commit | 578620f451f836389424833f1454eeeb2ffc9e9f (patch) | |
| tree | ef437c0575055652c7069b2874c655c569b1e572 | |
| parent | ext4: reject inodes with negative size (diff) | |
| download | linux-578620f451f836389424833f1454eeeb2ffc9e9f.tar.xz linux-578620f451f836389424833f1454eeeb2ffc9e9f.zip | |
ext4: return -ENOMEM instead of success
We should set the error code if kzalloc() fails.
Fixes: 67cf5b09a46f ("ext4: add the basic function for inline data support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
| -rw-r--r-- | fs/ext4/inline.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index 9b67f75bdcf7..437df6a1a841 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -341,8 +341,10 @@ static int ext4_update_inline_data(handle_t *handle, struct inode *inode, len -= EXT4_MIN_INLINE_DATA_SIZE; value = kzalloc(len, GFP_NOFS); - if (!value) + if (!value) { + error = -ENOMEM; goto out; + } error = ext4_xattr_ibody_get(inode, i.name_index, i.name, value, len); |