diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-07-30 00:52:21 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2019-07-31 17:19:04 +0200 |
| commit | 7f5d7425748d1cc2dadb6966ec84363d3342b5a1 (patch) | |
| tree | 2e395c3996f9498f2a818512d9142ae81254a0de | |
| parent | dmaengine: tegra210-adma: Don't program FIFO threshold (diff) | |
| download | linux-7f5d7425748d1cc2dadb6966ec84363d3342b5a1.tar.xz linux-7f5d7425748d1cc2dadb6966ec84363d3342b5a1.zip | |
dmaengine: imx-dma: Mark expected switch fall-through
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning (Building: arm):
drivers/dma/imx-dma.c: In function ‘imxdma_xfer_desc’:
drivers/dma/imx-dma.c:542:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (slot == IMX_DMA_2D_SLOT_A) {
^
drivers/dma/imx-dma.c:559:2: note: here
case IMXDMA_DESC_MEMCPY:
^~~~
Notice that, in this particular case, the code comment is
modified in accordance with what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20190729225221.GA24269@embeddedor
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/imx-dma.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c index 00a089e24150..5c0fb3134825 100644 --- a/drivers/dma/imx-dma.c +++ b/drivers/dma/imx-dma.c @@ -556,6 +556,7 @@ static int imxdma_xfer_desc(struct imxdma_desc *d) * We fall-through here intentionally, since a 2D transfer is * similar to MEMCPY just adding the 2D slot configuration. */ + /* Fall through */ case IMXDMA_DESC_MEMCPY: imx_dmav1_writel(imxdma, d->src, DMA_SAR(imxdmac->channel)); imx_dmav1_writel(imxdma, d->dest, DMA_DAR(imxdmac->channel)); |