diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2011-07-21 20:01:42 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-07-21 20:01:42 +0200 |
| commit | b91da88fed84843313a1b6fd1b1c834a24bbcf9e (patch) | |
| tree | 0c9456266a09f247a875fd3b55073ad42dc7445d | |
| parent | FS-Cache: Fix __fscache_uncache_all_inode_pages()'s outer loop (diff) | |
| download | linux-b91da88fed84843313a1b6fd1b1c834a24bbcf9e.tar.xz linux-b91da88fed84843313a1b6fd1b1c834a24bbcf9e.zip | |
vfs: drop conditional inode prefetch in __do_lookup_rcu
It seems to hurt performance in real life. Yes, the inode will be used
later, but the conditional doesn't seem to predict all that well
(negative dentries are not uncommon) and it looks like the cost of
prefetching is simply higher than depending on the cache doing the right
thing.
As usual.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/dcache.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/dcache.c b/fs/dcache.c index 6e4ea6d87774..fbdcbca40725 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1813,8 +1813,6 @@ seqretry: tname = dentry->d_name.name; i = dentry->d_inode; prefetch(tname); - if (i) - prefetch(i); /* * This seqcount check is required to ensure name and * len are loaded atomically, so as not to walk off the |