diff options
| author | Geert Uytterhoeven <geert@linux-m68k.org> | 2016-10-20 06:41:48 +0200 |
|---|---|---|
| committer | Dave Chinner <david@fromorbit.com> | 2016-10-20 06:41:48 +0200 |
| commit | 1be7f9be0efa4e90547f50b8188f4e70710a1173 (patch) | |
| tree | f08149589bee3be8ee9ea4cc73a09ddf6a4d34c5 | |
| parent | xfs: remove redundant assignment of ifp (diff) | |
| download | linux-1be7f9be0efa4e90547f50b8188f4e70710a1173.tar.xz linux-1be7f9be0efa4e90547f50b8188f4e70710a1173.zip | |
xfs: Fix uninitialized variable in xfs_reflink_reserve_cow_range()
with gcc 4.1.2:
fs/xfs/xfs_reflink.c: In function xfs_reflink_reserve_cow_range:
fs/xfs/xfs_reflink.c:327: warning: error may be used uninitialized in this function
Indeed, if "count" is zero, the function will return an uninitialized
error value.
While "count" is unlikely to be zero, this function is called through
the public iomap API. Hence fix this by preinitializing error to zero.
Fixes: 2a06705cd5954030 ("xfs: create delalloc extents in CoW fork")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
| -rw-r--r-- | fs/xfs/xfs_reflink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 5965e9455d91..d48a7cc2fe00 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -324,7 +324,7 @@ xfs_reflink_reserve_cow_range( struct xfs_mount *mp = ip->i_mount; xfs_fileoff_t offset_fsb, end_fsb; bool skipped = false; - int error; + int error = 0; trace_xfs_reflink_reserve_cow_range(ip, offset, count); |