summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian Foster <bfoster@redhat.com>2020-05-08 17:50:52 +0200
committerDarrick J. Wong <darrick.wong@oracle.com>2020-05-08 17:50:52 +0200
commit43dc0aa84ef74e3acd908b6d5eaa8ae15d7ecc8a (patch)
tree8d90c1397f5d1be62c0e2364c77c85e7f990c2d6
parentxfs: remove unnecessary includes from xfs_log_recover.c (diff)
downloadlinux-43dc0aa84ef74e3acd908b6d5eaa8ae15d7ecc8a.tar.xz
linux-43dc0aa84ef74e3acd908b6d5eaa8ae15d7ecc8a.zip
xfs: fix unused variable warning in buffer completion on !DEBUG
The random buffer write failure errortag patch introduced a local mount pointer variable for the test macro, but the macro is compiled out on !DEBUG kernels. This results in an unused variable warning. Access the mount structure through the buffer pointer and remove the local mount pointer to address the warning. Fixes: 7376d745473 ("xfs: random buffer write failure errortag") Signed-off-by: Brian Foster <bfoster@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
-rw-r--r--fs/xfs/xfs_buf.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index 9d8841ac7375..9c2fbb6bbf89 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -1289,11 +1289,10 @@ xfs_buf_bio_end_io(
struct bio *bio)
{
struct xfs_buf *bp = (struct xfs_buf *)bio->bi_private;
- struct xfs_mount *mp = bp->b_mount;
if (!bio->bi_status &&
(bp->b_flags & XBF_WRITE) && (bp->b_flags & XBF_ASYNC) &&
- XFS_TEST_ERROR(false, mp, XFS_ERRTAG_BUF_IOERROR))
+ XFS_TEST_ERROR(false, bp->b_mount, XFS_ERRTAG_BUF_IOERROR))
bio->bi_status = BLK_STS_IOERR;
/*