summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>2020-09-02 23:21:24 +0200
committerTakashi Iwai <tiwai@suse.de>2020-09-03 09:26:52 +0200
commit5656a7a06f0d5d90025f05c59424eb03d66e0039 (patch)
tree06df71adfa60951b9b79e4f0dd0bc1b93bc5e211
parentALSA: core: init: use DECLARE_COMPLETION_ONSTACK() macro (diff)
downloadlinux-5656a7a06f0d5d90025f05c59424eb03d66e0039.tar.xz
linux-5656a7a06f0d5d90025f05c59424eb03d66e0039.zip
ALSA: aoa: i2sbus: use DECLARE_COMPLETION_ONSTACK() macro
Follow recommendation in Documentation/scheduler/completion.rst and use macro to declare local 'struct completion' Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20200902212133.30964-10-pierre-louis.bossart@linux.intel.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/aoa/soundbus/i2sbus/pcm.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/aoa/soundbus/i2sbus/pcm.c b/sound/aoa/soundbus/i2sbus/pcm.c
index d350dbd24305..1c8e8131a716 100644
--- a/sound/aoa/soundbus/i2sbus/pcm.c
+++ b/sound/aoa/soundbus/i2sbus/pcm.c
@@ -254,12 +254,11 @@ static void i2sbus_wait_for_stop(struct i2sbus_dev *i2sdev,
struct pcm_info *pi)
{
unsigned long flags;
- struct completion done;
+ DECLARE_COMPLETION_ONSTACK(done);
long timeout;
spin_lock_irqsave(&i2sdev->low_lock, flags);
if (pi->dbdma_ring.stopping) {
- init_completion(&done);
pi->stop_completion = &done;
spin_unlock_irqrestore(&i2sdev->low_lock, flags);
timeout = wait_for_completion_timeout(&done, HZ);