diff options
| author | zhong jiang <zhongjiang@huawei.com> | 2019-09-04 12:03:28 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-09-04 19:14:46 +0200 |
| commit | 59d45f2a4d4a9fbea07f285994cae31ac13f2493 (patch) | |
| tree | d77e5d5e1229bd17efbefc61dcc703482f0a998e | |
| parent | staging: exfat: Fix two missing unlocks on error paths (diff) | |
| download | linux-59d45f2a4d4a9fbea07f285994cae31ac13f2493.tar.xz linux-59d45f2a4d4a9fbea07f285994cae31ac13f2493.zip | |
staging: exfat: remove the redundant check when kfree an object in exfat_destroy_inode
kfree has taken the null check in account. hence it is unnecessary to add the
null check before kfree the object. Just remove it.
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Link: https://lore.kernel.org/r/1567591408-24268-1-git-send-email-zhongjiang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/exfat/exfat_super.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 95bb606766b6..46ff33688c42 100644 --- a/drivers/staging/exfat/exfat_super.c +++ b/drivers/staging/exfat/exfat_super.c @@ -3498,8 +3498,7 @@ static struct inode *exfat_alloc_inode(struct super_block *sb) static void exfat_destroy_inode(struct inode *inode) { - if (EXFAT_I(inode)->target) - kfree(EXFAT_I(inode)->target); + kfree(EXFAT_I(inode)->target); EXFAT_I(inode)->target = NULL; kmem_cache_free(exfat_inode_cachep, EXFAT_I(inode)); |