diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-05-03 14:28:39 +0200 |
|---|---|---|
| committer | Leon Romanovsky <leonro@mellanox.com> | 2019-05-28 16:35:06 +0200 |
| commit | 6cc070bdf07c8f6d5955d43da0560c9e5fd203b1 (patch) | |
| tree | 590f158e23f7646dc447e01e7adbb8471eceb82e | |
| parent | Linux 5.2-rc1 (diff) | |
| download | linux-6cc070bdf07c8f6d5955d43da0560c9e5fd203b1.tar.xz linux-6cc070bdf07c8f6d5955d43da0560c9e5fd203b1.zip | |
net/mlx5: potential error pointer dereference in error handling
The error handling was a bit flipped around. If the mlx5_create_flow_group()
function failed then it would have resulted in dereferencing "fg" when
it was an error pointer.
Fixes: 80f09dfc237f ("net/mlx5: Eswitch, enable RoCE loopback traffic")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/rdma.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/rdma.c b/drivers/net/ethernet/mellanox/mlx5/core/rdma.c index 86f77456f873..401441aefbcb 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/rdma.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/rdma.c @@ -106,10 +106,10 @@ static int mlx5_rdma_enable_roce_steering(struct mlx5_core_dev *dev) return 0; -destroy_flow_table: - mlx5_destroy_flow_table(ft); destroy_flow_group: mlx5_destroy_flow_group(fg); +destroy_flow_table: + mlx5_destroy_flow_table(ft); free: kvfree(spec); kvfree(flow_group_in); |