summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndi Shyti <andi@etezian.org>2013-08-28 20:00:00 +0200
committerTheodore Ts'o <tytso@mit.edu>2013-08-28 20:00:00 +0200
commit27b1b22882d32aa711ab4801700dad997440d940 (patch)
treed7e1da3eac994ca4af12b588ab20379bfb6211b3
parentext4: fix lost truncate due to race with writeback (diff)
downloadlinux-27b1b22882d32aa711ab4801700dad997440d940.tar.xz
linux-27b1b22882d32aa711ab4801700dad997440d940.zip
ext4: fix use of potentially uninitialized variables in debugging code
If ext_debugging is enabled and path[depth].p_ext is NULL, len and lblock are printed non initialized Signed-off-by: Andi Shyti <andi@etezian.org> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
-rw-r--r--fs/ext4/extents.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 62b21ccea882..e7580aeb6fbc 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2285,8 +2285,8 @@ ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path,
ext4_lblk_t block)
{
int depth = ext_depth(inode);
- unsigned long len;
- ext4_lblk_t lblock;
+ unsigned long len = 0;
+ ext4_lblk_t lblock = 0;
struct ext4_extent *ex;
ex = path[depth].p_ext;
@@ -2323,7 +2323,6 @@ ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path,
ext4_es_insert_extent(inode, lblock, len, ~0,
EXTENT_STATUS_HOLE);
} else {
- lblock = len = 0;
BUG();
}