summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBruno Prémont <bonbons@linux-vserver.org>2012-08-19 19:33:02 +0200
committerJiri Kosina <jkosina@suse.cz>2012-09-05 11:48:07 +0200
commit63583c64558853f0fe7f8166907417792d184e18 (patch)
treef77dee08c6f833a64016ec993fe85222e0fd27ee
parentHID: picoLCD: Add support for CIR (diff)
downloadlinux-63583c64558853f0fe7f8166907417792d184e18.tar.xz
linux-63583c64558853f0fe7f8166907417792d184e18.zip
HID: picoLCD: optimize for inactive debugfs
Matthieu CASTET adjusted picolcd_debug_out_report() to only operate when there is an active listener on debugfs for events. Do the same on the more important picolcd_debug_raw_event() that is called in interrupt context as opposed to picolcd_debug_out_report() which happens in whichever context that sends reports to device. Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/hid-picolcd_debugfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-picolcd_debugfs.c b/drivers/hid/hid-picolcd_debugfs.c
index 15c22f2ee748..2c7308c2ae1f 100644
--- a/drivers/hid/hid-picolcd_debugfs.c
+++ b/drivers/hid/hid-picolcd_debugfs.c
@@ -657,7 +657,7 @@ void picolcd_debug_raw_event(struct picolcd_data *data,
#define BUFF_SZ 256
/* Avoid unnecessary overhead if debugfs is disabled */
- if (!hdev->debug_events)
+ if (list_empty(&hdev->debug_list))
return;
buff = kmalloc(BUFF_SZ, GFP_ATOMIC);