summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJingoo Han <jg1.han@samsung.com>2013-09-23 03:36:24 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-09-26 18:13:54 +0200
commit8221b3a8480bcfdc68bae0ee00bbf0d313759149 (patch)
tree0d6cd85c28113c57d881dba095abe0c81bea328b
parentmisc: tifm: remove unnecessary pci_set_drvdata() (diff)
downloadlinux-8221b3a8480bcfdc68bae0ee00bbf0d313759149.tar.xz
linux-8221b3a8480bcfdc68bae0ee00bbf0d313759149.zip
misc: ibmasm: remove unnecessary pci_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/misc/ibmasm/module.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/misc/ibmasm/module.c b/drivers/misc/ibmasm/module.c
index 0c290e40ce06..6b3bf9ab051d 100644
--- a/drivers/misc/ibmasm/module.c
+++ b/drivers/misc/ibmasm/module.c
@@ -153,7 +153,6 @@ error_ioremap:
error_heartbeat:
ibmasm_event_buffer_exit(sp);
error_eventbuffer:
- pci_set_drvdata(pdev, NULL);
kfree(sp);
error_kmalloc:
pci_release_regions(pdev);
@@ -182,7 +181,6 @@ static void ibmasm_remove_one(struct pci_dev *pdev)
ibmasm_free_remote_input_dev(sp);
iounmap(sp->base_address);
ibmasm_event_buffer_exit(sp);
- pci_set_drvdata(pdev, NULL);
kfree(sp);
pci_release_regions(pdev);
pci_disable_device(pdev);