diff options
| author | Felipe Balbi <balbi@ti.com> | 2012-04-27 10:02:15 +0200 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2012-04-27 10:02:15 +0200 |
| commit | 83a787a71e034244a9fd1d5988fe18f226341417 (patch) | |
| tree | 4ed07aa897320c5f1f24a77209ca0543be0be58b | |
| parent | usb: gadget: dummy: do not call pullup() on udc_stop() (diff) | |
| download | linux-83a787a71e034244a9fd1d5988fe18f226341417.tar.xz linux-83a787a71e034244a9fd1d5988fe18f226341417.zip | |
usb: gadget: udc-core: fix wrong call order
commit 6d258a4 (usb: gadget: udc-core: stop UDC on device-initiated
disconnect) introduced another case of asymmetric calls when issuing
a device-initiated disconnect. Fix it.
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Felipe Balbi <balbi@ti.com>
| -rw-r--r-- | drivers/usb/gadget/udc-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c index 2fa9865babed..df1bd87232dd 100644 --- a/drivers/usb/gadget/udc-core.c +++ b/drivers/usb/gadget/udc-core.c @@ -415,9 +415,9 @@ static ssize_t usb_udc_softconn_store(struct device *dev, usb_gadget_udc_start(udc->gadget, udc->driver); usb_gadget_connect(udc->gadget); } else if (sysfs_streq(buf, "disconnect")) { + usb_gadget_disconnect(udc->gadget); if (udc_is_newstyle(udc)) usb_gadget_udc_stop(udc->gadget, udc->driver); - usb_gadget_disconnect(udc->gadget); } else { dev_err(dev, "unsupported command '%s'\n", buf); return -EINVAL; |