diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2021-07-15 09:43:27 +0200 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-07-15 10:27:20 +0200 |
| commit | 95edbbf78c3bdbd1daa921dd4a2e61c751e469ba (patch) | |
| tree | 58334fa61e4612bebc9163fe6d861920190f6423 | |
| parent | platform/x86: wireless-hotkey: remove hardcoded "hp" from the error message (diff) | |
| download | linux-95edbbf78c3bdbd1daa921dd4a2e61c751e469ba.tar.xz linux-95edbbf78c3bdbd1daa921dd4a2e61c751e469ba.zip | |
platform/x86: amd-pmc: Fix missing unlock on error in amd_pmc_send_cmd()
Add the missing unlock before return from function amd_pmc_send_cmd()
in the error handling case.
Fixes: 95e1b60f8dc8 ("platform/x86: amd-pmc: Fix command completion code")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210715074327.1966083-1-yangyingliang@huawei.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
| -rw-r--r-- | drivers/platform/x86/amd-pmc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c index 680f94c7e075..663a4ca0580d 100644 --- a/drivers/platform/x86/amd-pmc.c +++ b/drivers/platform/x86/amd-pmc.c @@ -275,7 +275,7 @@ static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set, u32 *data, u8 msg PMC_MSG_DELAY_MIN_US * RESPONSE_REGISTER_LOOP_MAX); if (rc) { dev_err(dev->dev, "failed to talk to SMU\n"); - return rc; + goto out_unlock; } /* Write zero to response register */ |