summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteve French <stfrench@microsoft.com>2020-05-13 17:27:16 +0200
committerSteve French <stfrench@microsoft.com>2020-05-14 17:30:03 +0200
commit9bd21d4b1a767c3abebec203342f3820dcb84662 (patch)
treeb658b8584f20bf1c62b9ac0531a1ef84be41b91a
parentCIFS: Spelling s/EACCESS/EACCES/ (diff)
downloadlinux-9bd21d4b1a767c3abebec203342f3820dcb84662.tar.xz
linux-9bd21d4b1a767c3abebec203342f3820dcb84662.zip
cifs: Fix null pointer check in cifs_read
Coverity scan noted a redundant null check Coverity-id: 728517 Reported-by: Coverity <scan-admin@coverity.com> Signed-off-by: Steve French <stfrench@microsoft.com> Reviewed-by: Shyam Prasad N <nspmangalore@gmail.com>
-rw-r--r--fs/cifs/file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 0b1528edebcf..75ddce8ef456 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -4060,7 +4060,7 @@ cifs_read(struct file *file, char *read_data, size_t read_size, loff_t *offset)
* than it negotiated since it will refuse the read
* then.
*/
- if ((tcon->ses) && !(tcon->ses->capabilities &
+ if (!(tcon->ses->capabilities &
tcon->ses->server->vals->cap_large_files)) {
current_read_size = min_t(uint,
current_read_size, CIFSMaxBufSize);