diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2023-07-27 09:16:33 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2023-07-27 11:53:45 +0200 |
| commit | 367ef1e1c4b65acc5d789ba00d20197eb66b62f4 (patch) | |
| tree | 18c10d134fdbf5b34e159fec11bf04dfbe96d11e | |
| parent | Merge tag 'asoc-v6.6-early' of https://git.kernel.org/pub/scm/linux/kernel/gi... (diff) | |
| download | linux-367ef1e1c4b65acc5d789ba00d20197eb66b62f4.tar.xz linux-367ef1e1c4b65acc5d789ba00d20197eb66b62f4.zip | |
ALSA: hda/cs35l56: Do some clean up on probe error
Smatch complains that this return should be a goto:
sound/pci/hda/cs35l56_hda.c:910 cs35l56_hda_common_probe()
warn: missing unwind goto?
The goto error disables cansleep so that seems reasonable.
Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/465160f4-b7cf-41d5-931e-d6c9e68fa3c7@moroto.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/hda/cs35l56_hda.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c index 71e95e64f8a4..4c3279f61b94 100644 --- a/sound/pci/hda/cs35l56_hda.c +++ b/sound/pci/hda/cs35l56_hda.c @@ -907,7 +907,7 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int id) ret = cs35l56_set_patch(&cs35l56->base); if (ret) - return ret; + goto err; regcache_mark_dirty(cs35l56->base.regmap); regcache_sync(cs35l56->base.regmap); |