summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2023-08-16 08:35:25 +0200
committerTakashi Iwai <tiwai@suse.de>2023-08-16 08:36:07 +0200
commit409896794380c1dc0d596bbb9255e583a94d9a00 (patch)
tree51ed8c149c0b334beef79421740abfebe965dd34
parentALSA: hda: cs35l41: Support systems with missing _DSD properties (diff)
downloadlinux-409896794380c1dc0d596bbb9255e583a94d9a00.tar.xz
linux-409896794380c1dc0d596bbb9255e583a94d9a00.zip
ALSA: hda: cs35l41: Fix the loop check in cs35l41_add_dsd_properties
model->hid is a pointer, and should be rather NULL-checked in the loop of cs35l41_prop_model_table. Fixes: ef4ba63f12b0 ("ALSA: hda: cs35l41: Support systems with missing _DSD properties") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202308160506.8lCEeFDG-lkp@intel.com/ Link: https://lore.kernel.org/r/20230816063525.23009-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/pci/hda/cs35l41_hda_property.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
index 673f23257a09..48dcc3f1ef88 100644
--- a/sound/pci/hda/cs35l41_hda_property.c
+++ b/sound/pci/hda/cs35l41_hda_property.c
@@ -61,7 +61,7 @@ int cs35l41_add_dsd_properties(struct cs35l41_hda *cs35l41, struct device *physd
{
const struct cs35l41_prop_model *model;
- for (model = cs35l41_prop_model_table; model->hid > 0; model++) {
+ for (model = cs35l41_prop_model_table; model->hid; model++) {
if (!strcmp(model->hid, hid) &&
(!model->ssid ||
(cs35l41->acpi_subsystem_id &&