diff options
| author | Thomas Zimmermann <tzimmermann@suse.de> | 2023-04-28 14:24:45 +0200 |
|---|---|---|
| committer | Thomas Zimmermann <tzimmermann@suse.de> | 2023-05-08 15:28:33 +0200 |
| commit | 5a2c399d609bff499fdebfc5d80d8a5fc720630e (patch) | |
| tree | fe39ed2c73630e3011dc4e3db4eecc78a9d045e8 | |
| parent | fbdev/udlfb: Use struct fb_info.screen_buffer (diff) | |
| download | linux-5a2c399d609bff499fdebfc5d80d8a5fc720630e.tar.xz linux-5a2c399d609bff499fdebfc5d80d8a5fc720630e.zip | |
fbdev/vfb: Use struct fb_info.screen_buffer
Use info->screen_buffer when reading and writing framebuffers in
system memory. It's the correct pointer for this address space.
The struct fb_info has a union to store the framebuffer memory. This can
either be info->screen_base if the framebuffer is stored in I/O memory,
or info->screen_buffer if the framebuffer is stored in system memory.
As the driver operates on the latter address space, it is wrong to use
.screen_base and .screen_buffer must be used instead. This also gets
rid of casting needed due to not using the correct data type.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230428122452.4856-13-tzimmermann@suse.de
| -rw-r--r-- | drivers/video/fbdev/vfb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/fbdev/vfb.c b/drivers/video/fbdev/vfb.c index 95d3c59867d0..0ea611dd2759 100644 --- a/drivers/video/fbdev/vfb.c +++ b/drivers/video/fbdev/vfb.c @@ -439,7 +439,7 @@ static int vfb_probe(struct platform_device *dev) if (!info) goto err; - info->screen_base = (char __iomem *)videomemory; + info->screen_buffer = videomemory; info->fbops = &vfb_ops; if (!fb_find_mode(&info->var, info, mode_option, |