summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJayachandran C <c.jayachandran@gmail.com>2006-04-12 02:25:38 +0200
committerDavid S. Miller <davem@davemloft.net>2006-04-12 02:25:38 +0200
commit7ad4d2f6901437ba4717a26d395a73ea362d25c6 (patch)
treef72f0ef556e201ecb0911c5c2cad03bda2116d4f
parent[DCCP]: Fix leak in net/dccp/ipv4.c (diff)
downloadlinux-7ad4d2f6901437ba4717a26d395a73ea362d25c6.tar.xz
linux-7ad4d2f6901437ba4717a26d395a73ea362d25c6.zip
[BRIDGE] ebtables: fix allocation in net/bridge/netfilter/ebtables.c
Allocate an array of 'struct ebt_chainstack *', the current code allocates array of 'struct ebt_chainstack'. akpm: converted to use the foo = alloc(sizeof(*foo)) form. Which would have prevented this from happening in the first place. akpm: also removed unneeded typecast. akpm: what on earth is this code doing anyway? cpu_possible_map can be sparse.. Signed-off-by: Jayachandran C. <c.jayachandran@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/bridge/netfilter/ebtables.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index 66bd93252c4e..84b9af76f0a2 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -824,9 +824,9 @@ static int translate_table(struct ebt_replace *repl,
if (udc_cnt) {
/* this will get free'd in do_replace()/ebt_register_table()
if an error occurs */
- newinfo->chainstack = (struct ebt_chainstack **)
- vmalloc((highest_possible_processor_id()+1)
- * sizeof(struct ebt_chainstack));
+ newinfo->chainstack =
+ vmalloc((highest_possible_processor_id()+1)
+ * sizeof(*(newinfo->chainstack)));
if (!newinfo->chainstack)
return -ENOMEM;
for_each_possible_cpu(i) {