summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Healy <cphealy@gmail.com>2020-07-07 22:32:05 +0200
committerDavid S. Miller <davem@davemloft.net>2020-07-08 00:51:08 +0200
commit8cb601f15886f6d05479e46913d954e9ff237312 (patch)
tree27012ae9d8748a86a887a0c1c15733dcfb238606
parentnet/sched: Use fallthrough pseudo-keyword (diff)
downloadlinux-8cb601f15886f6d05479e46913d954e9ff237312.tar.xz
linux-8cb601f15886f6d05479e46913d954e9ff237312.zip
net: sfp: add error checking with sfp_irq_name
Add error checking with sfp_irq_name before use. Signed-off-by: Chris Healy <cphealy@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/phy/sfp.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 7bdfcde98266..eef458ab0e5b 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -2354,6 +2354,9 @@ static int sfp_probe(struct platform_device *pdev)
"%s-%s", dev_name(sfp->dev),
gpio_of_names[i]);
+ if (!sfp_irq_name)
+ return -ENOMEM;
+
err = devm_request_threaded_irq(sfp->dev, sfp->gpio_irq[i],
NULL, sfp_irq,
IRQF_ONESHOT |