diff options
| author | Nikolay Aleksandrov <nikolay@cumulusnetworks.com> | 2018-10-17 21:34:34 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-10-18 07:35:42 +0200 |
| commit | eddf016b910486d2123675a6b5fd7d64f77cdca8 (patch) | |
| tree | cb22890e3b2e6d84060ef74398364db06279302d | |
| parent | net: mscc: ocelot: Fix comment in ocelot_vlant_wait_for_completion() (diff) | |
| download | linux-eddf016b910486d2123675a6b5fd7d64f77cdca8.tar.xz linux-eddf016b910486d2123675a6b5fd7d64f77cdca8.zip | |
net: ipmr: fix unresolved entry dumps
If the skb space ends in an unresolved entry while dumping we'll miss
some unresolved entries. The reason is due to zeroing the entry counter
between dumping resolved and unresolved mfc entries. We should just
keep counting until the whole table is dumped and zero when we move to
the next as we have a separate table counter.
Reported-by: Colin Ian King <colin.king@canonical.com>
Fixes: 8fb472c09b9d ("ipmr: improve hash scalability")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/ipmr_base.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/ipv4/ipmr_base.c b/net/ipv4/ipmr_base.c index 1ad9aa62a97b..eab8cd5ec2f5 100644 --- a/net/ipv4/ipmr_base.c +++ b/net/ipv4/ipmr_base.c @@ -296,8 +296,6 @@ int mr_rtm_dumproute(struct sk_buff *skb, struct netlink_callback *cb, next_entry: e++; } - e = 0; - s_e = 0; spin_lock_bh(lock); list_for_each_entry(mfc, &mrt->mfc_unres_queue, list) { |