diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-27 20:33:45 +0200 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2018-07-27 20:59:07 +0200 |
| commit | 1f25d9c60cfe28524f1650912bc13d72854206b5 (patch) | |
| tree | 1546a8664dd5f0a43f40660550c8115a73eb38ea | |
| parent | Input: keyspan_remote - replace GFP_ATOMIC with GFP_KERNEL in keyspan_probe() (diff) | |
| download | linux-1f25d9c60cfe28524f1650912bc13d72854206b5.tar.xz linux-1f25d9c60cfe28524f1650912bc13d72854206b5.zip | |
Input: powermate - replace GFP_ATOMIC with GFP_KERNEL in powermate_alloc_buffers()
powermate_alloc_buffers() is never called in atomic context. It calls
usb_alloc_coherent() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC
can be replaced with GFP_KERNEL.
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
| -rw-r--r-- | drivers/input/misc/powermate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/misc/powermate.c b/drivers/input/misc/powermate.c index 5c8c79623c87..e8de3aaf9f63 100644 --- a/drivers/input/misc/powermate.c +++ b/drivers/input/misc/powermate.c @@ -277,7 +277,7 @@ static int powermate_input_event(struct input_dev *dev, unsigned int type, unsig static int powermate_alloc_buffers(struct usb_device *udev, struct powermate_device *pm) { pm->data = usb_alloc_coherent(udev, POWERMATE_PAYLOAD_SIZE_MAX, - GFP_ATOMIC, &pm->data_dma); + GFP_KERNEL, &pm->data_dma); if (!pm->data) return -1; |