diff options
| author | Gustavo Pimentel <Gustavo.Pimentel@synopsys.com> | 2020-10-21 23:28:10 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-11-03 10:11:44 +0100 |
| commit | 33fcc5491897504856783335102142676dbee817 (patch) | |
| tree | 5a5939a8d07e66b42efeed2b5e8bf5fd343c7894 | |
| parent | misc: ti-st: st_core: remove unneeded semicolon (diff) | |
| download | linux-33fcc5491897504856783335102142676dbee817.tar.xz linux-33fcc5491897504856783335102142676dbee817.zip | |
misc: pci_endpoint_test: Remove unnecessary verification
The first condition of the if statement can never be true, because
bar variable is an enum variable type defined between 0 and 5, and
also bar variable acquires the value from arg function parameter which
is an unsigned long variable.
The constant 5 was replaced the the equivalent enum type, in this case
BAR_5.
Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Link: https://lore.kernel.org/r/142cbbc215bed4243a219ea17b46f4256ceccb22.1603315690.git.gustavo.pimentel@synopsys.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/misc/pci_endpoint_test.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index 146ca6fb3260..ea9c2c085298 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -708,7 +708,7 @@ static long pci_endpoint_test_ioctl(struct file *file, unsigned int cmd, switch (cmd) { case PCITEST_BAR: bar = arg; - if (bar < 0 || bar > 5) + if (bar > BAR_5) goto ret; if (is_am654_pci_dev(pdev) && bar == BAR_0) goto ret; |