diff options
| author | Kent Overstreet <kmo@daterainc.com> | 2013-12-07 12:57:58 +0100 |
|---|---|---|
| committer | Kent Overstreet <kmo@daterainc.com> | 2014-01-08 22:05:14 +0100 |
| commit | 3b3e9e50dd951725130645660b526c4f367dcdee (patch) | |
| tree | 860b547a43c62e0e1b578c5f3adabbb3a031d5bd | |
| parent | bcache: Improve bucket_prio() calculation (diff) | |
| download | linux-3b3e9e50dd951725130645660b526c4f367dcdee.tar.xz linux-3b3e9e50dd951725130645660b526c4f367dcdee.zip | |
bcache: Don't return -EINTR when insert finished
We need to return -EINTR after a split because we invalidated iterators
(and freed the btree node) - but if we were finished inserting, we don't
want to redo the traversal.
Signed-off-by: Kent Overstreet <kmo@daterainc.com>
| -rw-r--r-- | drivers/md/bcache/btree.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c index 463d2800a955..98cc0a810a36 100644 --- a/drivers/md/bcache/btree.c +++ b/drivers/md/bcache/btree.c @@ -2002,8 +2002,10 @@ static int bch_btree_insert_node(struct btree *b, struct btree_op *op, return -EINTR; } else { /* Invalidated all iterators */ - return btree_split(b, op, insert_keys, replace_key) ?: - -EINTR; + int ret = btree_split(b, op, insert_keys, replace_key); + + return bch_keylist_empty(insert_keys) ? + 0 : ret ?: -EINTR; } } else { BUG_ON(write_block(b) != btree_bset_last(b)); |