diff options
| author | Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> | 2021-12-09 09:13:07 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-12-09 16:50:32 +0100 |
| commit | 4cd8371a234d051f9c9557fcbb1f8c523b1c0d10 (patch) | |
| tree | b68402a21e402fd2405ea0a85ed9534441422047 | |
| parent | nfc: fix segfault in nfc_genl_dump_devices_done (diff) | |
| download | linux-4cd8371a234d051f9c9557fcbb1f8c523b1c0d10.tar.xz linux-4cd8371a234d051f9c9557fcbb1f8c523b1c0d10.zip | |
nfc: fix potential NULL pointer deref in nfc_genl_dump_ses_done
The done() netlink callback nfc_genl_dump_ses_done() should check if
received argument is non-NULL, because its allocation could fail earlier
in dumpit() (nfc_genl_dump_ses()).
Fixes: ac22ac466a65 ("NFC: Add a GET_SE netlink API")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20211209081307.57337-1-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | net/nfc/netlink.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c index 0b4fae183a4b..f184b0db79d4 100644 --- a/net/nfc/netlink.c +++ b/net/nfc/netlink.c @@ -1394,8 +1394,10 @@ static int nfc_genl_dump_ses_done(struct netlink_callback *cb) { struct class_dev_iter *iter = (struct class_dev_iter *) cb->args[0]; - nfc_device_iter_exit(iter); - kfree(iter); + if (iter) { + nfc_device_iter_exit(iter); + kfree(iter); + } return 0; } |