diff options
| author | Jiri Kosina <jkosina@suse.cz> | 2016-06-20 11:16:18 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2016-06-20 11:16:18 +0200 |
| commit | 63b3a7d0f933ebf25961e602c2eb11d658fef912 (patch) | |
| tree | e4284b2b56b5466ec70bb6009b33129c56d1e0ce | |
| parent | HID: alps: struct u1_dev *priv is internal to the driver (diff) | |
| download | linux-63b3a7d0f933ebf25961e602c2eb11d658fef912.tar.xz linux-63b3a7d0f933ebf25961e602c2eb11d658fef912.zip | |
HID: alps: pass correct sizes to hid_hw_raw_request()
Calculating size of the report as sizeof(pointer) always passess the length
corresponding to the pointer type, not the underlying data report.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
| -rw-r--r-- | drivers/hid/hid-alps.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 098bce621c6c..ff64c92906a6 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c @@ -136,7 +136,8 @@ static int u1_read_write_register(struct hid_device *hdev, u32 address, input[7] = check_sum; ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, input, - sizeof(input), HID_FEATURE_REPORT, HID_REQ_SET_REPORT); + sizeof(u8)*U1_FEATURE_REPORT_LEN, HID_FEATURE_REPORT, + HID_REQ_SET_REPORT); if (ret < 0) { dev_err(&hdev->dev, "failed to read command (%d)\n", ret); @@ -145,8 +146,8 @@ static int u1_read_write_register(struct hid_device *hdev, u32 address, if (read_flag) { ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, readbuf, - sizeof(readbuf), HID_FEATURE_REPORT, - HID_REQ_GET_REPORT); + sizeof(u8)*U1_FEATURE_REPORT_LEN, + HID_FEATURE_REPORT, HID_REQ_GET_REPORT); if (ret < 0) { dev_err(&hdev->dev, "failed read register (%d)\n", ret); |