diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-04-25 21:30:23 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-04-26 16:13:43 +0200 |
| commit | 6cefb6264277c073030a3b2d91ba6b28593b4c89 (patch) | |
| tree | f9d73ff394a225a36afce628a61d3c517d472049 | |
| parent | ASoC: qcom: SC7280: Update machine driver startup, shutdown callbacks (diff) | |
| download | linux-6cefb6264277c073030a3b2d91ba6b28593b4c89.tar.xz linux-6cefb6264277c073030a3b2d91ba6b28593b4c89.zip | |
ASoC: pcm1789: Make pcm1789_common_exit() return void
This function returns zero unconditionally, so there isn't any benefit
of returning a value. Make it return void to be able to see at a glance
that the return value of pcm1789_i2c_remove() is always zero.
This patch is a preparation for making i2c remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220425193023.61046-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/codecs/pcm1789-i2c.c | 4 | ||||
| -rw-r--r-- | sound/soc/codecs/pcm1789.c | 4 | ||||
| -rw-r--r-- | sound/soc/codecs/pcm1789.h | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/sound/soc/codecs/pcm1789-i2c.c b/sound/soc/codecs/pcm1789-i2c.c index 28e6ca2ad3a4..1d2f7480a6e4 100644 --- a/sound/soc/codecs/pcm1789-i2c.c +++ b/sound/soc/codecs/pcm1789-i2c.c @@ -29,7 +29,9 @@ static int pcm1789_i2c_probe(struct i2c_client *client) static int pcm1789_i2c_remove(struct i2c_client *client) { - return pcm1789_common_exit(&client->dev); + pcm1789_common_exit(&client->dev); + + return 0; } #ifdef CONFIG_OF diff --git a/sound/soc/codecs/pcm1789.c b/sound/soc/codecs/pcm1789.c index 620dec172ce7..35788b57e11f 100644 --- a/sound/soc/codecs/pcm1789.c +++ b/sound/soc/codecs/pcm1789.c @@ -259,13 +259,11 @@ int pcm1789_common_init(struct device *dev, struct regmap *regmap) } EXPORT_SYMBOL_GPL(pcm1789_common_init); -int pcm1789_common_exit(struct device *dev) +void pcm1789_common_exit(struct device *dev) { struct pcm1789_private *priv = dev_get_drvdata(dev); flush_work(&priv->work); - - return 0; } EXPORT_SYMBOL_GPL(pcm1789_common_exit); diff --git a/sound/soc/codecs/pcm1789.h b/sound/soc/codecs/pcm1789.h index c446d789ed48..79439c8322b3 100644 --- a/sound/soc/codecs/pcm1789.h +++ b/sound/soc/codecs/pcm1789.h @@ -12,6 +12,6 @@ extern const struct regmap_config pcm1789_regmap_config; int pcm1789_common_init(struct device *dev, struct regmap *regmap); -int pcm1789_common_exit(struct device *dev); +void pcm1789_common_exit(struct device *dev); #endif |