summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Richter <tmricht@linux.ibm.com>2019-10-31 10:38:53 +0100
committerVasily Gorbik <gor@linux.ibm.com>2019-11-12 11:24:10 +0100
commit72fbcd057fa1d25da70e33312a0c8401d4295599 (patch)
treed826803c97995dfa2510c8264ad2a9c689ec9b98
parents390/cpum_sf: Replace function name in debug statements (diff)
downloadlinux-72fbcd057fa1d25da70e33312a0c8401d4295599.tar.xz
linux-72fbcd057fa1d25da70e33312a0c8401d4295599.zip
s390/cpum_sf: Assign error value to err variable
When starting the CPU Measurement sampling facility using qsi() function, this function may return an error value. This error value is referenced in the else part of the if statement to dump its value in a debug statement. Right now this value is always zero because it has not been assigned a value. Signed-off-by: Thomas Richter <tmricht@linux.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
-rw-r--r--arch/s390/kernel/perf_cpum_sf.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c
index e7587343e272..69506fdbd9a1 100644
--- a/arch/s390/kernel/perf_cpum_sf.c
+++ b/arch/s390/kernel/perf_cpum_sf.c
@@ -1007,7 +1007,8 @@ static void cpumsf_pmu_disable(struct pmu *pmu)
}
/* Save state of TEAR and DEAR register contents */
- if (!qsi(&si)) {
+ err = qsi(&si);
+ if (!err) {
/* TEAR/DEAR values are valid only if the sampling facility is
* enabled. Note that cpumsf_pmu_disable() might be called even
* for a disabled sampling facility because cpumsf_pmu_enable()