diff options
| author | Sakari Ailus <sakari.ailus@linux.intel.com> | 2023-12-06 18:24:11 +0100 |
|---|---|---|
| committer | Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2023-12-08 10:04:12 +0100 |
| commit | 843750fb85fda6111c78e5c40e5ca5bc7dde6d10 (patch) | |
| tree | f762841b8b924df81b34857b68c5e0177c3daabd | |
| parent | media: rj54n1cb0c: Don't set format in sub-device state (diff) | |
| download | linux-843750fb85fda6111c78e5c40e5ca5bc7dde6d10.tar.xz linux-843750fb85fda6111c78e5c40e5ca5bc7dde6d10.zip | |
media: tw9910: Don't set format in sub-device state
For the purpose of setting old non-pad based sub-device try format as a
basis for VIDIOC_TRY_FMT implementation, there is no need to set the
format in the sub-device state. Drop the assignment to the state, which
would result in a NULL pointer dereference.
Fixes: fd17e3a9a788 ("media: i2c: Use accessors for pad config 'try_*' fields")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
| -rw-r--r-- | drivers/media/i2c/tw9910.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c index 7c331a7f12d4..905af98c7d53 100644 --- a/drivers/media/i2c/tw9910.c +++ b/drivers/media/i2c/tw9910.c @@ -829,8 +829,6 @@ static int tw9910_set_fmt(struct v4l2_subdev *sd, if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE) return tw9910_s_fmt(sd, mf); - *v4l2_subdev_state_get_format(sd_state, 0) = *mf; - return 0; } |