summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>2020-05-28 16:50:50 +0200
committerArnd Bergmann <arnd@arndb.de>2020-05-28 16:57:12 +0200
commit91920088536fa1cf01ceedbfb96219699d088756 (patch)
tree83854240f368c085711c233312645384bfba282c
parentbus: bt1-axi: Optimize the return points in the driver (diff)
downloadlinux-91920088536fa1cf01ceedbfb96219699d088756.tar.xz
linux-91920088536fa1cf01ceedbfb96219699d088756.zip
bus: bt1-axi: Use sysfs_streq instead of strncmp
There is a ready-to-use method to compare a retrieved from a sysfs node string with another string. It treats both NUL and newline-then-NUL as equivalent string terminations. So use it instead of manually truncating the line length in the strncmp() method. Link: https://lore.kernel.org/r/20200528145050.5203-6-Sergey.Semin@baikalelectronics.ru Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> Cc: Olof Johansson <olof@lixom.net> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: soc@kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de>
-rw-r--r--drivers/bus/bt1-axi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/bus/bt1-axi.c b/drivers/bus/bt1-axi.c
index c194d9a2bbeb..e7a6744acc7b 100644
--- a/drivers/bus/bt1-axi.c
+++ b/drivers/bus/bt1-axi.c
@@ -220,9 +220,9 @@ static ssize_t inject_error_store(struct device *dev,
* error while unaligned writing - the AXI bus write error handled
* by this driver.
*/
- if (!strncmp(data, "bus", 3))
+ if (sysfs_streq(data, "bus"))
readb(axi->qos_regs);
- else if (!strncmp(data, "unaligned", 9))
+ else if (sysfs_streq(data, "unaligned"))
writeb(0, axi->qos_regs);
else
return -EINVAL;