summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Zanussi <tom.zanussi@linux.intel.com>2015-12-10 19:50:48 +0100
committerSteven Rostedt <rostedt@goodmis.org>2016-03-08 17:19:34 +0100
commita5863dae84e2da83a1e5de485a7f150d0c28f08e (patch)
tree4fc823d2b4c49168d706097cdc0a2bbe8c4575af
parenttracing: Add a per-event-trigger 'paused' field (diff)
downloadlinux-a5863dae84e2da83a1e5de485a7f150d0c28f08e.tar.xz
linux-a5863dae84e2da83a1e5de485a7f150d0c28f08e.zip
tracing: Add needs_rec flag to event triggers
Add a new needs_rec flag for triggers that require unconditional access to trace records in order to function. Normally a trigger requires access to the contents of a trace record only if it has a filter associated with it (since filters need the contents of a record in order to make a filtering decision). Some types of triggers, such as 'hist' triggers, require access to trace record contents independent of the presence of filters, so add a new flag for those triggers. Link: http://lkml.kernel.org/r/7be8fa38f9b90fdb6c47ca0f98d20a07b9fd512b.1449767187.git.tom.zanussi@linux.intel.com Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> Tested-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Reviewed-by: Namhyung Kim <namhyung@kernel.org> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-rw-r--r--kernel/trace/trace.h7
-rw-r--r--kernel/trace/trace_events_trigger.c3
2 files changed, 9 insertions, 1 deletions
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index f1868677f856..8c6aefbb24d2 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -1292,6 +1292,12 @@ struct event_trigger_ops {
* itself logs to the trace buffer, this flag should be set,
* otherwise it can be left unspecified.
*
+ * @needs_rec: A flag that says whether or not this command needs
+ * access to the trace record in order to perform its function,
+ * regardless of whether or not it has a filter associated with
+ * it (filters make a trigger require access to the trace record
+ * but are not always present).
+ *
* All the methods below, except for @set_filter(), must be
* implemented.
*
@@ -1332,6 +1338,7 @@ struct event_command {
char *name;
enum event_trigger_type trigger_type;
bool post_trigger;
+ bool needs_rec;
int (*func)(struct event_command *cmd_ops,
struct trace_event_file *file,
char *glob, char *cmd, char *params);
diff --git a/kernel/trace/trace_events_trigger.c b/kernel/trace/trace_events_trigger.c
index e4d8b3763175..a11bb4780f82 100644
--- a/kernel/trace/trace_events_trigger.c
+++ b/kernel/trace/trace_events_trigger.c
@@ -493,7 +493,8 @@ void update_cond_flag(struct trace_event_file *file)
bool set_cond = false;
list_for_each_entry_rcu(data, &file->triggers, list) {
- if (data->filter || data->cmd_ops->post_trigger) {
+ if (data->filter || data->cmd_ops->post_trigger ||
+ data->cmd_ops->needs_rec) {
set_cond = true;
break;
}