diff options
| author | Eric Dumazet <edumazet@google.com> | 2016-11-16 14:49:22 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-11-17 17:17:05 +0100 |
| commit | bb07fafaec70183f1dcd3d4a1459abbc409753e2 (patch) | |
| tree | 37d68ef70a7d48ef58e661473eb3a61256b95e53 | |
| parent | Merge branch 'mlxsw-i2c' (diff) | |
| download | linux-bb07fafaec70183f1dcd3d4a1459abbc409753e2.tar.xz linux-bb07fafaec70183f1dcd3d4a1459abbc409753e2.zip | |
net/mlx4_en: remove napi_hash_del() call
There is no need calling napi_hash_del()+synchronize_rcu() before
calling netif_napi_del()
netif_napi_del() does this already.
Using napi_hash_del() in a driver is useful only when dealing with
a batch of NAPI structures, so that a single synchronize_rcu() can
be used. mlx4_en_deactivate_cq() is deactivating a single NAPI.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/en_cq.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_cq.c b/drivers/net/ethernet/mellanox/mlx4/en_cq.c index 03f05c4d1f98..09dd3776db76 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_cq.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_cq.c @@ -185,10 +185,6 @@ void mlx4_en_destroy_cq(struct mlx4_en_priv *priv, struct mlx4_en_cq **pcq) void mlx4_en_deactivate_cq(struct mlx4_en_priv *priv, struct mlx4_en_cq *cq) { napi_disable(&cq->napi); - if (cq->type == RX) { - napi_hash_del(&cq->napi); - synchronize_rcu(); - } netif_napi_del(&cq->napi); mlx4_cq_free(priv->mdev->dev, &cq->mcq); |