diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2012-11-06 22:55:32 +0100 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2012-11-16 05:44:27 +0100 |
| commit | c37472d3f4ec6bf98b443490e069f31d18bcd6f5 (patch) | |
| tree | a2d207a112fcae949c27f80aac84d6296d973350 | |
| parent | pata_arasan: Initialize cf clock to 166MHz (diff) | |
| download | linux-c37472d3f4ec6bf98b443490e069f31d18bcd6f5.tar.xz linux-c37472d3f4ec6bf98b443490e069f31d18bcd6f5.zip | |
sata_highbank: mark ahci_highbank_probe as __devinit
The ahci_highbank_probe function is incorrectly marked as __init,
which means it can get discarded at boot time, which might be
a problem if for some reason the device only becomes operational
after loading another module.
Using __devinit instead avoids seeing this warning for every build:
WARNING: vmlinux.o(.data+0xf7b0): Section mismatch in reference from the
variable ahci_highbank_driver to the function .init.text:ahci_highbank_probe()
The variable ahci_highbank_driver references
the function __init ahci_highbank_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Mark Langsdorf <mark.langsdorf@calxeda.com>
Cc: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
| -rw-r--r-- | drivers/ata/sata_highbank.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c index 0d7c4c2cd26f..36a141a2b22b 100644 --- a/drivers/ata/sata_highbank.c +++ b/drivers/ata/sata_highbank.c @@ -260,7 +260,7 @@ static const struct of_device_id ahci_of_match[] = { }; MODULE_DEVICE_TABLE(of, ahci_of_match); -static int __init ahci_highbank_probe(struct platform_device *pdev) +static int __devinit ahci_highbank_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct ahci_host_priv *hpriv; |