summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Meyer <thomas@m3y3r.de>2011-11-10 19:27:42 +0100
committerGreg Kroah-Hartman <gregkh@suse.de>2011-11-15 19:21:55 +0100
commiteb545522944d9dcff66ff45d321bb6e6d44d0075 (patch)
tree9befa976e0e31ba465dd58543b6e2aa067d1aac9
parentusb: storage: shuttle_usbat: fix sparse warning (diff)
downloadlinux-eb545522944d9dcff66ff45d321bb6e6d44d0075.tar.xz
linux-eb545522944d9dcff66ff45d321bb6e6d44d0075.zip
USB: Realtek cr: Use kmemdup rather than duplicating its implementation
Use kmemdup rather than duplicating its implementation The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/storage/realtek_cr.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
index 30f64bfe101e..71147679cb11 100644
--- a/drivers/usb/storage/realtek_cr.c
+++ b/drivers/usb/storage/realtek_cr.c
@@ -398,10 +398,9 @@ static int rts51x_write_mem(struct us_data *us, u16 addr, u8 *data, u16 len)
u8 cmnd[12] = { 0 };
u8 *buf;
- buf = kmalloc(len, GFP_NOIO);
+ buf = kmemdup(data, len, GFP_NOIO);
if (buf == NULL)
return USB_STOR_TRANSPORT_ERROR;
- memcpy(buf, data, len);
US_DEBUGP("%s, addr = 0x%x, len = %d\n", __func__, addr, len);