diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-10-12 17:39:29 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2021-10-17 07:42:14 +0200 |
| commit | efb389b8c34fa7da673eb0a598b223bd891daa9d (patch) | |
| tree | 34622a812729370bd051276e8dab38023713f125 | |
| parent | hwmon: (acpi_power_meter) Use acpi_bus_get_acpi_device() (diff) | |
| download | linux-efb389b8c34fa7da673eb0a598b223bd891daa9d.tar.xz linux-efb389b8c34fa7da673eb0a598b223bd891daa9d.zip | |
hwmon: (max31722) Warn about failure to put device in stand-by in .remove()
When an spi driver's remove function returns a non-zero error code
nothing happens apart from emitting a generic error message. Make this
error message more device specific and return zero instead.
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20211012153945.2651412-5-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/max31722.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/hwmon/max31722.c b/drivers/hwmon/max31722.c index 613338cbcb17..4cf4fe6809a3 100644 --- a/drivers/hwmon/max31722.c +++ b/drivers/hwmon/max31722.c @@ -103,10 +103,16 @@ static int max31722_probe(struct spi_device *spi) static int max31722_remove(struct spi_device *spi) { struct max31722_data *data = spi_get_drvdata(spi); + int ret; hwmon_device_unregister(data->hwmon_dev); - return max31722_set_mode(data, MAX31722_MODE_STANDBY); + ret = max31722_set_mode(data, MAX31722_MODE_STANDBY); + if (ret) + /* There is nothing we can do about this ... */ + dev_warn(&spi->dev, "Failed to put device in stand-by mode\n"); + + return 0; } static int __maybe_unused max31722_suspend(struct device *dev) |