diff options
| author | Petr Mladek <pmladek@suse.com> | 2022-06-23 16:51:53 +0200 |
|---|---|---|
| committer | Petr Mladek <pmladek@suse.com> | 2022-06-23 18:41:40 +0200 |
| commit | 05c96b3713aa2a406d0c4ef0505bf80a6748fedb (patch) | |
| tree | d6f705499b2731a75747a9eaf0e541a8c5d70ec6 | |
| parent | Revert "printk: Wait for the global console lock when the system is going down" (diff) | |
| download | linux-05c96b3713aa2a406d0c4ef0505bf80a6748fedb.tar.xz linux-05c96b3713aa2a406d0c4ef0505bf80a6748fedb.zip | |
Revert "printk: Block console kthreads when direct printing will be required"
This reverts commit c3230283e2819a69dad2cf7a63143fde8bab8b5c.
The testing of 5.19 release candidates revealed missing synchronization
between early and regular console functionality.
It would be possible to start the console kthreads later as a workaround.
But it is clear that console lock serialized console drivers between
each other. It opens a big area of possible problems that were not
considered by people involved in the development and review.
printk() is crucial for debugging kernel issues and console output is
very important part of it. The number of consoles is huge and a proper
review would take some time. As a result it need to be reverted for 5.19.
Link: https://lore.kernel.org/r/YrBdjVwBOVgLfHyb@alley
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20220623145157.21938-3-pmladek@suse.com
| -rw-r--r-- | kernel/printk/printk.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 45c6c2b0b104..ea3dd55709e7 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -3729,9 +3729,7 @@ static bool printer_should_wake(struct console *con, u64 seq) return true; if (con->blocked || - console_kthreads_atomically_blocked() || - system_state > SYSTEM_RUNNING || - oops_in_progress) { + console_kthreads_atomically_blocked()) { return false; } |