diff options
| author | Paulo Alcantara <pc@cjr.nz> | 2020-04-21 04:44:24 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2020-04-23 03:29:11 +0200 |
| commit | 0fe0781f29dd8ab618999e6bda33c782ebbdb109 (patch) | |
| tree | 6466c4c7d089eb0a93bf4630c726358f44ad01e6 | |
| parent | cifs: ensure correct super block for DFS reconnect (diff) | |
| download | linux-0fe0781f29dd8ab618999e6bda33c782ebbdb109.tar.xz linux-0fe0781f29dd8ab618999e6bda33c782ebbdb109.zip | |
cifs: fix uninitialised lease_key in open_shroot()
SMB2_open_init() expects a pre-initialised lease_key when opening a
file with a lease, so set pfid->lease_key prior to calling it in
open_shroot().
This issue was observed when performing some DFS failover tests and
the lease key was never randomly generated.
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
CC: Stable <stable@vger.kernel.org>
| -rw-r--r-- | fs/cifs/smb2ops.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index b36c46f48705..f829f4165d38 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -687,6 +687,11 @@ int open_shroot(unsigned int xid, struct cifs_tcon *tcon, if (smb3_encryption_required(tcon)) flags |= CIFS_TRANSFORM_REQ; + if (!server->ops->new_lease_key) + return -EIO; + + server->ops->new_lease_key(pfid); + memset(rqst, 0, sizeof(rqst)); resp_buftype[0] = resp_buftype[1] = CIFS_NO_BUFFER; memset(rsp_iov, 0, sizeof(rsp_iov)); |