diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2020-01-14 00:42:32 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-01-14 20:48:41 +0100 |
| commit | 2670ee77c99c76f46c061caf65daa2e2bfb5dcc5 (patch) | |
| tree | 4431b36bee854a456174a3aeeab0ce7a030fec68 | |
| parent | net: ipv4: use skb_list_walk_safe helper for gso segments (diff) | |
| download | linux-2670ee77c99c76f46c061caf65daa2e2bfb5dcc5.tar.xz linux-2670ee77c99c76f46c061caf65daa2e2bfb5dcc5.zip | |
net: netfilter: use skb_list_walk_safe helper for gso segments
This is a straight-forward conversion case for the new function, keeping
the flow of the existing code as intact as possible.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/netfilter/nfnetlink_queue.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c index feabdfb22920..76535fd9278c 100644 --- a/net/netfilter/nfnetlink_queue.c +++ b/net/netfilter/nfnetlink_queue.c @@ -778,7 +778,7 @@ nfqnl_enqueue_packet(struct nf_queue_entry *entry, unsigned int queuenum) { unsigned int queued; struct nfqnl_instance *queue; - struct sk_buff *skb, *segs; + struct sk_buff *skb, *segs, *nskb; int err = -ENOBUFS; struct net *net = entry->state.net; struct nfnl_queue_net *q = nfnl_queue_pernet(net); @@ -815,8 +815,7 @@ nfqnl_enqueue_packet(struct nf_queue_entry *entry, unsigned int queuenum) goto out_err; queued = 0; err = 0; - do { - struct sk_buff *nskb = segs->next; + skb_list_walk_safe(segs, segs, nskb) { if (err == 0) err = __nfqnl_enqueue_packet_gso(net, queue, segs, entry); @@ -824,8 +823,7 @@ nfqnl_enqueue_packet(struct nf_queue_entry *entry, unsigned int queuenum) queued++; else kfree_skb(segs); - segs = nskb; - } while (segs); + } if (queued) { if (err) /* some segments are already queued */ |