diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2024-04-10 15:35:06 +0200 |
|---|---|---|
| committer | Andreas Larsson <andreas@gaisler.com> | 2024-04-22 16:51:57 +0200 |
| commit | 9f2072ca33520f5be6e89f410d0e82df72f7821d (patch) | |
| tree | be9d2efae0ff873f30aaa26dc6a8cf277efbec42 | |
| parent | sparc: Compare pointers to NULL instead of 0 (diff) | |
| download | linux-9f2072ca33520f5be6e89f410d0e82df72f7821d.tar.xz linux-9f2072ca33520f5be6e89f410d0e82df72f7821d.zip | |
sparc: parport: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Andreas Larsson <andreas@gaisler.com>
Link: https://lore.kernel.org/r/2765e090dba2d99f92e16c92b6aa55090aae053b.1712755381.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Andreas Larsson <andreas@gaisler.com>
| -rw-r--r-- | arch/sparc/include/asm/parport_64.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/arch/sparc/include/asm/parport_64.h b/arch/sparc/include/asm/parport_64.h index 0a7ffcfd59cd..4f530a270760 100644 --- a/arch/sparc/include/asm/parport_64.h +++ b/arch/sparc/include/asm/parport_64.h @@ -196,7 +196,7 @@ out_err: return err; } -static int ecpp_remove(struct platform_device *op) +static void ecpp_remove(struct platform_device *op) { struct parport *p = dev_get_drvdata(&op->dev); int slot = p->dma; @@ -216,8 +216,6 @@ static int ecpp_remove(struct platform_device *op) d_len); clear_bit(slot, dma_slot_map); } - - return 0; } static const struct of_device_id ecpp_match[] = { @@ -245,7 +243,7 @@ static struct platform_driver ecpp_driver = { .of_match_table = ecpp_match, }, .probe = ecpp_probe, - .remove = ecpp_remove, + .remove_new = ecpp_remove, }; static int parport_pc_find_nonpci_ports(int autoirq, int autodma) |