diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-01-12 15:34:14 +0100 |
|---|---|---|
| committer | Benjamin Tissoires <bentiss@kernel.org> | 2024-01-15 11:54:08 +0100 |
| commit | a9668169961106f3598384fe95004106ec191201 (patch) | |
| tree | e77bc27808fafec575e4e5be68e10f0fdb80f96e | |
| parent | Merge tag 'hid-for-linus-2024010801' of git://git.kernel.org/pub/scm/linux/ke... (diff) | |
| download | linux-a9668169961106f3598384fe95004106ec191201.tar.xz linux-a9668169961106f3598384fe95004106ec191201.zip | |
HID: hid-steam: remove pointless error message
This error message doesn't really add any information. If modprobe
fails then the user will already know what the error code is. In the
case of kmalloc() it's a style violation to print an error message for
that because kmalloc has it's own better error messages built in.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Vicki Pfau <vi@endrift.com>
Link: https://lore.kernel.org/r/305898fb-6bd4-4749-806c-05ec51bbeb80@moroto.mountain
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
| -rw-r--r-- | drivers/hid/hid-steam.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index b3c4e50e248a..59df6ead7b54 100644 --- a/drivers/hid/hid-steam.c +++ b/drivers/hid/hid-steam.c @@ -1109,10 +1109,9 @@ static int steam_probe(struct hid_device *hdev, return hid_hw_start(hdev, HID_CONNECT_DEFAULT); steam = devm_kzalloc(&hdev->dev, sizeof(*steam), GFP_KERNEL); - if (!steam) { - ret = -ENOMEM; - goto steam_alloc_fail; - } + if (!steam) + return -ENOMEM; + steam->hdev = hdev; hid_set_drvdata(hdev, steam); spin_lock_init(&steam->lock); @@ -1179,9 +1178,6 @@ hid_hw_start_fail: cancel_work_sync(&steam->work_connect); cancel_delayed_work_sync(&steam->mode_switch); cancel_work_sync(&steam->rumble_work); -steam_alloc_fail: - hid_err(hdev, "%s: failed with error %d\n", - __func__, ret); return ret; } |