diff options
| author | Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> | 2020-05-19 20:14:16 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-05-22 02:04:53 +0200 |
| commit | d28ea1fbbf437054ef339afec241019f2c4e2bb6 (patch) | |
| tree | d9fad8e096e79975fafe84815dc8fbbd5dac9219 | |
| parent | ethtool: count header size in reply size estimate (diff) | |
| download | linux-d28ea1fbbf437054ef339afec241019f2c4e2bb6.tar.xz linux-d28ea1fbbf437054ef339afec241019f2c4e2bb6.zip | |
net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()
Once the traversal of the list is completed with list_for_each_entry(),
the iterator (node) will point to an invalid object. So passing this to
qrtr_local_enqueue() which is outside of the iterator block is erroneous
eventhough the object is not used.
So fix this by passing NULL to qrtr_local_enqueue().
Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/qrtr/qrtr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 7ed31b5e77e4..2d8d6131bc5f 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -854,7 +854,7 @@ static int qrtr_bcast_enqueue(struct qrtr_node *node, struct sk_buff *skb, } mutex_unlock(&qrtr_node_lock); - qrtr_local_enqueue(node, skb, type, from, to); + qrtr_local_enqueue(NULL, skb, type, from, to); return 0; } |