diff options
| author | Leon Romanovsky <leonro@mellanox.com> | 2020-05-17 13:53:40 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-05-17 21:43:49 +0200 |
| commit | e3f2d5579c0b8ad9d1fb6a5813cee38a86386e05 (patch) | |
| tree | f70ac8ac5df4e7a89ae861ca52aa1dbd52c83b64 | |
| parent | net: revert "net: get rid of an signed integer overflow in ip_idents_reserve()" (diff) | |
| download | linux-e3f2d5579c0b8ad9d1fb6a5813cee38a86386e05.tar.xz linux-e3f2d5579c0b8ad9d1fb6a5813cee38a86386e05.zip | |
net: phy: propagate an error back to the callers of phy_sfp_probe
The compilation warning below reveals that the errors returned from
the sfp_bus_add_upstream() call are not propagated to the callers.
Fix it by returning "ret".
14:37:51 drivers/net/phy/phy_device.c: In function 'phy_sfp_probe':
14:37:51 drivers/net/phy/phy_device.c:1236:6: warning: variable 'ret'
set but not used [-Wunused-but-set-variable]
14:37:51 1236 | int ret;
14:37:51 | ^~~
Fixes: 298e54fa810e ("net: phy: add core phylib sfp support")
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/phy_device.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index ac2784192472..697c74deb222 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1233,7 +1233,7 @@ int phy_sfp_probe(struct phy_device *phydev, const struct sfp_upstream_ops *ops) { struct sfp_bus *bus; - int ret; + int ret = 0; if (phydev->mdio.dev.fwnode) { bus = sfp_bus_find_fwnode(phydev->mdio.dev.fwnode); @@ -1245,7 +1245,7 @@ int phy_sfp_probe(struct phy_device *phydev, ret = sfp_bus_add_upstream(bus, phydev, ops); sfp_bus_put(bus); } - return 0; + return ret; } EXPORT_SYMBOL(phy_sfp_probe); |