summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authornikolay@redhat.com <nikolay@redhat.com>2013-04-06 02:54:37 +0200
committerDavid S. Miller <davem@davemloft.net>2013-04-08 22:45:09 +0200
commitffcdedb667b6db8ee31c7efa76a3ec59d9c3b0fc (patch)
tree6fc19386e085c0bff5930acc5256bd975ec6272d
parentMerge branch 'wireless' (diff)
downloadlinux-ffcdedb667b6db8ee31c7efa76a3ec59d9c3b0fc.tar.xz
linux-ffcdedb667b6db8ee31c7efa76a3ec59d9c3b0fc.zip
Revert "bonding: remove sysfs before removing devices"
This reverts commit 4de79c737b200492195ebc54a887075327e1ec1d. This patch introduces a new bug which causes access to freed memory. In bond_uninit: list_del(&bond->bond_list); bond_list is linked in bond_net's dev_list which is freed by unregister_pernet_subsys. Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/bonding/bond_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 171b10f167a5..a51241b2e621 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4902,8 +4902,8 @@ static void __exit bonding_exit(void)
bond_destroy_debugfs();
- unregister_pernet_subsys(&bond_net_ops);
rtnl_link_unregister(&bond_link_ops);
+ unregister_pernet_subsys(&bond_net_ops);
#ifdef CONFIG_NET_POLL_CONTROLLER
/*