summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTrond Myklebust <Trond.Myklebust@netapp.com>2012-07-17 20:47:30 +0200
committerTrond Myklebust <Trond.Myklebust@netapp.com>2012-07-17 23:02:57 +0200
commit013448c59b8a8cf71a5ff89641f78b620671ccb0 (patch)
tree60b6918d120e7ef00da6d650efed1717b9bd9762
parentNFS: Split out NFS v4 client functions (diff)
downloadlinux-013448c59b8a8cf71a5ff89641f78b620671ccb0.tar.xz
linux-013448c59b8a8cf71a5ff89641f78b620671ccb0.zip
SUNRPC: Add a missing spin_unlock to gss_mech_list_pseudoflavors
The patch "SUNRPC: Add rpcauth_list_flavors()" introduces a new error path in gss_mech_list_pseudoflavors, but fails to release the spin lock. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r--net/sunrpc/auth_gss/gss_mech_switch.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/net/sunrpc/auth_gss/gss_mech_switch.c b/net/sunrpc/auth_gss/gss_mech_switch.c
index 6ac5dfcd2928..b174fcd9ff4c 100644
--- a/net/sunrpc/auth_gss/gss_mech_switch.c
+++ b/net/sunrpc/auth_gss/gss_mech_switch.c
@@ -257,8 +257,10 @@ int gss_mech_list_pseudoflavors(rpc_authflavor_t *array_ptr, int size)
spin_lock(&registered_mechs_lock);
list_for_each_entry(pos, &registered_mechs, gm_list) {
for (j = 0; j < pos->gm_pf_num; j++) {
- if (i >= size)
+ if (i >= size) {
+ spin_unlock(&registered_mechs_lock);
return -ENOMEM;
+ }
array_ptr[i++] = pos->gm_pfs[j].pseudoflavor;
}
}