diff options
| author | Jason Xing <kernelxing@tencent.com> | 2024-03-08 12:25:04 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-03-11 11:37:40 +0100 |
| commit | 683a67da95616c91a85b98e41dc8eefe9f2b29e7 (patch) | |
| tree | 8db546ff0658cc827f43f0c66cb950d0942e411d | |
| parent | mptcp: annotate a data-race around sysctl_tcp_wmem[0] (diff) | |
| download | linux-683a67da95616c91a85b98e41dc8eefe9f2b29e7.tar.xz linux-683a67da95616c91a85b98e41dc8eefe9f2b29e7.zip | |
tcp: annotate a data-race around sysctl_tcp_wmem[0]
When reading wmem[0], it could be changed concurrently without
READ_ONCE() protection. So add one annotation here.
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/tcp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index b091149742b1..d20b62d52171 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -975,7 +975,7 @@ int tcp_wmem_schedule(struct sock *sk, int copy) * Use whatever is left in sk->sk_forward_alloc and tcp_wmem[0] * to guarantee some progress. */ - left = sock_net(sk)->ipv4.sysctl_tcp_wmem[0] - sk->sk_wmem_queued; + left = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_wmem[0]) - sk->sk_wmem_queued; if (left > 0) sk_forced_mem_schedule(sk, min(left, copy)); return min(copy, sk->sk_forward_alloc); |