diff options
| author | Adrian Hunter <adrian.hunter@intel.com> | 2022-10-05 12:19:41 +0200 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@linaro.org> | 2022-12-07 13:22:32 +0100 |
| commit | 8ff683f6a293650a7fa5025f41a164987b585f07 (patch) | |
| tree | 61e68e04ae1dcadc86863213f3fa7b92a4236ef2 | |
| parent | mmc: sdhci: Replace kmap_atomic() with kmap_local_page() (diff) | |
| download | linux-8ff683f6a293650a7fa5025f41a164987b585f07.tar.xz linux-8ff683f6a293650a7fa5025f41a164987b585f07.zip | |
mmc: bcm2835: Remove local_irq_{save,restore}() around k[un]map_atomic()
A long time ago the kmap_atomic API required a slot to be provided which
risked the possibility that other code might use the same slot at the
same time. Disabling interrupts prevented the possibility of an interrupt
handler doing that. However, that went away with
commit 3e4d3af501cc ("mm: stack based kmap_atomic()").
Unfortunately, that unnecessary pattern of code has been copied since
and persists in bcm2385.c.
Remove it.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20221005101951.3165-5-adrian.hunter@intel.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
| -rw-r--r-- | drivers/mmc/host/bcm2835.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c index 641ab4f42125..49acbfa87ab8 100644 --- a/drivers/mmc/host/bcm2835.c +++ b/drivers/mmc/host/bcm2835.c @@ -1068,7 +1068,6 @@ static void bcm2835_dma_complete_work(struct work_struct *work) } if (host->drain_words) { - unsigned long flags; void *page; u32 *buf; @@ -1076,7 +1075,6 @@ static void bcm2835_dma_complete_work(struct work_struct *work) host->drain_page += host->drain_offset >> PAGE_SHIFT; host->drain_offset &= ~PAGE_MASK; } - local_irq_save(flags); page = kmap_atomic(host->drain_page); buf = page + host->drain_offset; @@ -1089,7 +1087,6 @@ static void bcm2835_dma_complete_work(struct work_struct *work) } kunmap_atomic(page); - local_irq_restore(flags); } bcm2835_finish_data(host); |