diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2018-01-11 12:12:25 +0100 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2018-01-13 06:17:35 +0100 |
| commit | a24e7917e1758daf9ac0da4fac0f7b48f0b4b624 (patch) | |
| tree | 989e518115db338f69a1f71bbe0e1619f90bd50d | |
| parent | target_core_user: add cmd id to broken ring message (diff) | |
| download | linux-a24e7917e1758daf9ac0da4fac0f7b48f0b4b624.tar.xz linux-a24e7917e1758daf9ac0da4fac0f7b48f0b4b624.zip | |
tcmu: fix error return code in tcmu_configure_device()
Fix to return error code -ENOMEM from the kzalloc() error handling
case instead of 0, as done elsewhere in this function.
Fixes: 80eb876 ("tcmu: allow max block and global max blocks to be settable")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
| -rw-r--r-- | drivers/target/target_core_user.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 1238480cd4c4..60c8a87b7a88 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -1675,8 +1675,10 @@ static int tcmu_configure_device(struct se_device *dev) udev->data_bitmap = kzalloc(BITS_TO_LONGS(udev->max_blocks) * sizeof(unsigned long), GFP_KERNEL); - if (!udev->data_bitmap) + if (!udev->data_bitmap) { + ret = -ENOMEM; goto err_bitmap_alloc; + } udev->mb_addr = vzalloc(CMDR_SIZE); if (!udev->mb_addr) { |