diff options
| author | Martin Sperl <kernel@martin.sperl.org> | 2019-03-30 10:30:59 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-04-03 06:31:06 +0200 |
| commit | c7de8500fd8ecbb544846dd5f11dca578c3777e1 (patch) | |
| tree | 1de57f27eaf008b47135c316e2c1e289f45337a2 | |
| parent | spi: bcm2835aux: unifying code between polling and interrupt driven code (diff) | |
| download | linux-c7de8500fd8ecbb544846dd5f11dca578c3777e1.tar.xz linux-c7de8500fd8ecbb544846dd5f11dca578c3777e1.zip | |
spi: bcm2835aux: remove dangerous uncontrolled read of fifo
This read of the fifo is a potential candidate for a race condition
as the spi transfer is not necessarily finished and so can lead to
an early read of the fifo that still misses data.
So it has been removed.
Fixes: 1ea29b39f4c812ec ("spi: bcm2835aux: add bcm2835 auxiliary spi device...")
Suggested-by: Hubert Denkmair <h.denkmair@intence.de>
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-bcm2835aux.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c index 41366d0a16af..0838dbda57c7 100644 --- a/drivers/spi/spi-bcm2835aux.c +++ b/drivers/spi/spi-bcm2835aux.c @@ -194,13 +194,6 @@ static void bcm2835aux_spi_transfer_helper(struct bcm2835aux_spi *bs) BCM2835_AUX_SPI_STAT_TX_FULL))) { bcm2835aux_wr_fifo(bs); } - - /* and check if we have reached "done" */ - while (bs->rx_len && - (!(bcm2835aux_rd(bs, BCM2835_AUX_SPI_STAT) & - BCM2835_AUX_SPI_STAT_BUSY))) { - bcm2835aux_rd_fifo(bs); - } } static irqreturn_t bcm2835aux_spi_interrupt(int irq, void *dev_id) |