diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-01-27 14:13:34 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-01-28 14:05:18 +0100 |
| commit | fb25621da5702c104ce0a48de5b174ced09e5b4e (patch) | |
| tree | 4a94e98756422866881f7500293315d23a6dbb17 | |
| parent | ASoC: qdsp6: q6apm-dai: only stop graphs that are started (diff) | |
| download | linux-fb25621da5702c104ce0a48de5b174ced09e5b4e.tar.xz linux-fb25621da5702c104ce0a48de5b174ced09e5b4e.zip | |
ASoC: fsl: Add missing error handling in pcm030_fabric_probe
Add the missing platform_device_put() and platform_device_del()
before return from pcm030_fabric_probe in the error handling case.
Fixes: c912fa913446 ("ASoC: fsl: register the wm9712-codec")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220127131336.30214-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/fsl/pcm030-audio-fabric.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/sound/soc/fsl/pcm030-audio-fabric.c b/sound/soc/fsl/pcm030-audio-fabric.c index af3c3b90c0ac..83b4a22bf15a 100644 --- a/sound/soc/fsl/pcm030-audio-fabric.c +++ b/sound/soc/fsl/pcm030-audio-fabric.c @@ -93,16 +93,21 @@ static int pcm030_fabric_probe(struct platform_device *op) dev_err(&op->dev, "platform_device_alloc() failed\n"); ret = platform_device_add(pdata->codec_device); - if (ret) + if (ret) { dev_err(&op->dev, "platform_device_add() failed: %d\n", ret); + platform_device_put(pdata->codec_device); + } ret = snd_soc_register_card(card); - if (ret) + if (ret) { dev_err(&op->dev, "snd_soc_register_card() failed: %d\n", ret); + platform_device_del(pdata->codec_device); + platform_device_put(pdata->codec_device); + } platform_set_drvdata(op, pdata); - return ret; + } static int pcm030_fabric_remove(struct platform_device *op) |